Changed <a name="..."> to <a id="...">

[mikeschinkel]

When opening this repo in PhpStorm it flagged @name as a deprecated HTML attribute, so it seemed appropriate to change then to @id. In cases where there were both a @name and @id attribute and their values were the same, this commit removes the @name attribute (there were no cases where both @name and @id attributes existed but having different values.)

[cmb69]

Thank you! It might be more important, though, to also fix that in the scripts which are used to generate these entries, e.g.

web-php/bin/news2html

Line 98 in f16e2cb

$tag = "<a name=\"PHP_{$parts[0]}_{$parts[1]}\"></a>";

[mikeschinkel]

@cmb69 — lol! I didn't know that, but know I do! :-)

I will fix there and updated.

BTW, I also have a few other PRs are will add, each of which is very narrow so it will be easier to review.

[mikeschinkel]

@cmb69 — Where are these files? I can't find them in my cloned repo?

[cmb69]

One is bin/news2html. I think there is at least one other to generate the archive entries, but I'm not sure where that is (might be included/used from bin/createNewsEntry).

[mikeschinkel]

@cmb69 — Sorry, I just had a brain fart.

I was looking for the /f16e2cb6a3b0ea30a2c6a585180c20f12f941e82/ directory. Obviously it wasn't there, as that was a commit hash. Doh!

[mikeschinkel]

@cmb69 — PR updated to include news2html.php.

One additional question.

PhpStorm flagged line 72 as an error because of the \1:

array('<?php bugfix(\1); ?>', '<?php peclbugfix(\1); ?>', 
      '<?php implemented(\1); ?>', '<?php githubissuel(\'php/php-src\',\1); ?>'),

Is that valid in some earlier version of PHP that you might still be using? Shouldn't it be \$1 instead of just \1?:

array('<?php bugfix(\$1); ?>', '<?php peclbugfix(\$1); ?>', 
      '<?php implemented(\$1); ?>', '<?php githubissuel(\'php/php-src\',\$1); ?>'),

If yes I can either add that fix to this PR or create a new PR; whichever your preference.

[cmb69]

PhpStorm flagged line 72 as an error because of the \1:

Oh, right, this should more correctly be \\1 or even better $1. I'd prefer a separate PR.

[mikeschinkel]

@cmb69 — I believe this PR has addressed the issues you mention and should be ready to merge,

I created two other PRs to deal with the regex issue (#423) and a fix to allow news2html to process the only example NEWS files I could find in the repo (#417.)

[cmb69]

Thank you for the PR! Except for removing the table attributes this looks very good to me.