Change escaping function to build URL for searching #519
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
May 27, 2022
js/search.js
Outdated
| @@ -360,7 +360,7 @@ | |||
|
|
|||
| dropdown.append(searchTemplate.render({ | |||
| pattern: pattern, | |||
| url: "/search.php?pattern=" + escape(pattern) | |||
| url: "/search.php?pattern=" + pattern | |||
There was a problem hiding this comment.
I think we need to escape, but we should not use the very old escape() function, but rather encodeURIComponent() instead.
There was a problem hiding this comment.
Thanks for feedback.
I seem surely your feedback is right.
I will commit for using encodedURIComponent.
Can I commit as ammend and force push?
There was a problem hiding this comment.
Yes, you can amend and force-push, but you can also add a new commit and push. We usually squash before merging anyway.
There was a problem hiding this comment.
you can also add a new commit and push
I selected it and push new commit, thank you
attakei
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix #518
Note
Search form submits raw-text to
/search.php, butsearch.jsbuild url with escaped text.I think that it need not escape on JS too.
Ref: https://github.com/php/web-php/blob/master/include/header.inc#L127