Skip to content

Enhancement: Enable strict_param fixer #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 15, 2022

This pull request

  • enables the (risky) strict_param fixer
  • runs make coding-standards
  • sets the strict param to false to ensure the current behavior

Follows #559.

πŸ’β€β™‚οΈ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/strict/strict_param.rst.

@localheinz localheinz marked this pull request as ready for review July 15, 2022 11:27
@localheinz localheinz force-pushed the feature/strict-param branch from a76e29a to ce186ff Compare July 15, 2022 12:31
@localheinz localheinz force-pushed the feature/strict-param branch 3 times, most recently from eda1b07 to 631b38e Compare July 15, 2022 12:34
@localheinz localheinz force-pushed the feature/strict-param branch from 631b38e to 1e33e2c Compare July 15, 2022 12:35
@cmb69 cmb69 merged commit f127de5 into php:master Jul 15, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 15, 2022

Thank you!

@localheinz localheinz deleted the feature/strict-param branch July 15, 2022 13:20
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants