Skip to content

Fix: Return false instead of null #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 7, 2023

This pull request

  • returns false instead of null

Follows #406.

πŸ’β€β™‚οΈ Following the merge of #406 (after I applied suggestions made in code review), I can no longer serve the site locally by running

php -S localhost:8080 .router.php

@localheinz localheinz mentioned this pull request Dec 7, 2023
1 task
@localheinz localheinz force-pushed the fix/happy branch 4 times, most recently from bf30dae to 618f8bc Compare December 7, 2023 11:25
@localheinz localheinz changed the title Fix: Revert suggested changes Fix: Return false instead of null Dec 7, 2023
@derickr derickr merged commit 18dad7b into php:master Dec 7, 2023
@localheinz localheinz deleted the fix/happy branch December 7, 2023 11:48
@localheinz
Copy link
Contributor Author

Thank you, @derickr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants