Merge pull request #7 from nanasess/fix-each

Fix deprecated features in PHP 7.2.x

Author: nanasess

.travis.yml

@@ -8,6 +8,10 @@ php:
   - 5.6
   - "7.0"
   - "7.1"
+  - "7.2"
+  - "7.3"
+  - "7.4"
+  - "nightly"
 
 env:
   matrix:
@@ -35,6 +39,8 @@ matrix:
      - php: 5.5
        dist: trusty
        env: DEPENDENCIES="low"
+   allow_failures:
+     - php: nightly
 
 dist: xenial
 sudo: false

composer.json

@@ -28,7 +28,7 @@
         "phpunit/phpunit-mock-objects": "~2.3",
         "phpspec/prophecy": "^1.3.1",
         "symfony/yaml": "~2.1|~3.0",
-        "sebastian/comparator": "~1.2.2",
+        "sebastian/comparator": "~1.2.4",
         "sebastian/diff": "~1.2",
         "sebastian/environment": "~1.3",
         "sebastian/exporter": "~1.2",

src/Extensions/PhptTestCase.php

@@ -43,7 +43,6 @@ class PHPUnit_Extensions_PhptTestCase implements PHPUnit_Framework_Test, PHPUnit
         'report_memleaks=0',
         'report_zend_debug=0',
         'safe_mode=0',
-        'track_errors=1',
         'xdebug.default_enable=0'
     );
 

src/Util/Getopt.php

@@ -35,7 +35,10 @@ public static function getopt(array $args, $short_options, $long_options = null)
         reset($args);
         array_map('trim', $args);
 
-        while (list($i, $arg) = each($args)) {
+        while ($arg = current($args)) {
+            $i = key($args);
+            next($args);
+
             if ($arg == '') {
                 continue;
             }
@@ -94,8 +97,10 @@ protected static function parseShortOption($arg, $short_options, &$opts, &$args)
                     if ($i + 1 < $argLen) {
                         $opts[] = array($opt, substr($arg, $i + 1));
                         break;
-                    } elseif (list(, $opt_arg) = each($args)) {
+                    } elseif ($opt_arg = current($args)) {
+                        next($args);
                     } else {
+                        next($args);
                         throw new PHPUnit_Framework_Exception(
                             "option requires an argument -- $opt"
                         );
@@ -139,11 +144,14 @@ protected static function parseLongOption($arg, $long_options, &$opts, &$args)
 
             if (substr($long_opt, -1) == '=') {
                 if (substr($long_opt, -2) != '==') {
-                    if (!strlen($opt_arg) &&
-                        !(list(, $opt_arg) = each($args))) {
-                        throw new PHPUnit_Framework_Exception(
-                            "option --$opt requires an argument"
-                        );
+                    if (!strlen($opt_arg)) {
+                        $opt_arg = current($args);
+                        next($args);
+                        if (!($opt_arg)) {
+                            throw new PHPUnit_Framework_Exception(
+                                "option --$opt requires an argument"
+                            );
+                        }
                     }
                 }
             } elseif ($opt_arg) {