-
-
Notifications
You must be signed in to change notification settings - Fork 7
Php8 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php8 #39
Conversation
@jaapio
|
composer.json
Outdated
"php": "^7.2", | ||
"league/flysystem": "^1.0" | ||
"php": "^7.2||^8.0", | ||
"league/flysystem": "^1.0||^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library cannot be compatible with league/flysystem:^2.0
Since this is a plugin, which have been removed in flysystem 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see.
reverted the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, there is something going on with Github actions. Which I don't understand yet.
I think there is an invalid change in the composer.json regarding league/flysystem.
@jaapio Can you re-run the failing GitHub Action? It looks like it just failed to download the PHPUnit PHAR file. |
@jaapio, I've got an open PR that includes the changes in this PR as well as updates to get the GitHub Actions to properly run again. Would it be possible to have that reviewed? I'd really like to be able to run my test suite using PHP 8! |
closes #38