Skip to content

Conversation

jnkowa-gfk
Copy link
Contributor

closes #38

@jnkowa-gfk
Copy link
Contributor Author

@jaapio
having this liv available on php8 is required to bring phpdocumentor to a php8 support.

composer require --dev phpdocumentor/phpdocumentor:dev-master
Running composer update phpdocumentor/phpdocumentor
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - phpdocumentor/flyfinder 1.0.0 requires php ^7.2 -> your php version (8.0.2) does not satisfy that requirement.
    - phpdocumentor/phpdocumentor dev-master requires phpdocumentor/flyfinder ^1.0 -> satisfiable by phpdocumentor/flyfinder[1.0.0].
    - Root composer.json requires phpdocumentor/phpdocumentor dev-master -> satisfiable by phpdocumentor/phpdocumentor[dev-master].

composer.json Outdated
"php": "^7.2",
"league/flysystem": "^1.0"
"php": "^7.2||^8.0",
"league/flysystem": "^1.0||^2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library cannot be compatible with league/flysystem:^2.0 Since this is a plugin, which have been removed in flysystem 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see.
reverted the change.

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, there is something going on with Github actions. Which I don't understand yet.

I think there is an invalid change in the composer.json regarding league/flysystem.

@ancarda
Copy link

ancarda commented Mar 4, 2021

@jaapio Can you re-run the failing GitHub Action? It looks like it just failed to download the PHPUnit PHAR file.

@douglasmiller
Copy link
Contributor

@jaapio, I've got an open PR that includes the changes in this PR as well as updates to get the GitHub Actions to properly run again. Would it be possible to have that reviewed? I'd really like to be able to run my test suite using PHP 8!

@jaapio jaapio merged commit 46d79a3 into phpDocumentor:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any chance to bump PHP req to 8.* speedily?
4 participants