Adding support for PHP 8.x #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/douglasmiller/FlyFinder/pull/3 is a PR against my fork showing the GitHub actions workflow running to success. |
|
@jaapio, any thoughts on this update to get the tests to pass? |
|
There seems to be an issue on github with the approval of the workflow. I will try to run the workflow later. |
|
PR looks good to me. Thanks |
|
@douglasmiller thanks for the work and the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of @jnkowa-gfk's PR #39 which closes #38.
This extends #39 by updating the
phive.xmlfile to specify newerinstalledversions and an updated gpg key for @maglnet'sComposerRequireCheckerphar file.