AbstractList: fix array vs mixed difference #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```php /** * @param mixed[] $value */ public function someMethod(array $value) ... ``` is interpretted incorretly like `array`. That matters, because here it is useful - we **know** there is mixed ```php /** * @param array */ public function someMethod(array $value) ... ``` But here not, because we forget to specify the type. And it could be more `SomeType[]`, `string[]` etc.
|
Test would probably fail now. I fix them after feedback and more guidance where to solve this |
|
Your assumption seems to be correct to me. What would you want to know to continue this PR? |
Potentially, |
|
Not relevant anymore, I migrated to https://github.com/phpstan/phpdoc-parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is interpretted incorretly like
array. That matters, because here it is useful - we know there is mixedBut here not, because we forget to specify the type. And it could be more
SomeType[],string[]etc.