Introduce Transformer for Content Menus #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linawolf could you please rebase this pr? so I can review this :-) |
|
@jaapio this is ready for review |
jaapio
reviewed
Jul 7, 2023
packages/guides/src/Compiler/NodeTransformers/ContentMenuNodeWithSectionEntryTransformer.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
menu-3
branch
2 times, most recently
from
2819469 to
7599309
Compare
|
@jaapio thanks, that must have found its way back in by merging. Please review once more |
jaapio
approved these changes
Jul 7, 2023
This reintroduces the contents directive which was destroyed by switching to transformers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #443