-
-
Notifications
You must be signed in to change notification settings - Fork 15
Enable Multi level Menus #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@linawolf please rebase this one, so we can continue with a review :-) |
1febe75
to
49a4601
Compare
@jaapio rebased, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for now, some minor things that need to be addressed before we can merge this.
But as I said on Slack. I think we should have a closer look at what we want to store in the nodes. It feels like they are getting larger and larger every feature we add. But most of the new meta like information that is now stored in the documentnode should not be directly used by the renderer. Which means for me that it should not be in the nodes. It is more like our internal administration that nobody should ever look at.
During rendering the renderer should basically just look at nodes and child nodes. All properties exposed by the nodes should add value to the rendering. And I think the DocumentEntryNode doesn't do that. We want people to use the menu nodes an not trying to create there own menu tree in the templates to render a menu.
I think we can address this later.
...ges/guides/tests/unit/Compiler/NodeTransformers/DocumentEntryRegistrationTransformerTest.php
Outdated
Show resolved
Hide resolved
packages/guides/src/Compiler/NodeTransformers/TocNodeWithDocumentEntryTransformer.php
Outdated
Show resolved
Hide resolved
packages/guides/src/Compiler/NodeTransformers/TocNodeWithDocumentEntryTransformer.php
Outdated
Show resolved
Hide resolved
packages/guides/src/Compiler/NodeTransformers/TocNodeWithDocumentEntryTransformer.php
Outdated
Show resolved
Hide resolved
This reintroduces the contents directive which was destroyed by switching to transformers
To avoid circular relations we need to mark the root document.
@jaapio please have another look |
@jaapio I applied all suggested changes, please have another look |
To avoid circular relations we need to mark the root document.
depends on #455, which depends on #443