Refuse API key if user is disabled#293
Merged
Merged
Conversation
samtuke
approved these changes
Jun 21, 2018
Collaborator
Author
While testing the REST API, I noticed that disabled administrators are still able to generate API keys as well as use their existing ones. This adjusts the authentication logic to block access for disabled administrators. Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
xh3n1
force-pushed
the
block-disabled-admins
branch
from
9ad7af3 to
d2c83ae
Compare
oliverklee
approved these changes
Jun 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the REST API, I noticed that disabled administrators are still able to generate API keys as well as use their existing ones.
This adjusts the authentication logic to block access for disabled administrators.
The tests are currently failing on master, I will address those in another PR.