Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse API key if user is disabled #293

Merged
merged 1 commit into from Jun 22, 2018
Merged

Refuse API key if user is disabled #293

merged 1 commit into from Jun 22, 2018

Conversation

@xh3n1
Copy link
Member

@xh3n1 xh3n1 commented Jun 21, 2018

While testing the REST API, I noticed that disabled administrators are still able to generate API keys as well as use their existing ones.

This adjusts the authentication logic to block access for disabled administrators.

The tests are currently failing on master, I will address those in another PR.

@xh3n1 xh3n1 requested a review from samtuke Jun 21, 2018
@xh3n1
Copy link
Member Author

@xh3n1 xh3n1 commented Jun 21, 2018

Once #294 and #295 are merged all tests should be green again and I will rebase.

While testing the REST API, I noticed that disabled administrators are still able to generate API keys as well as use their existing ones.

This adjusts the authentication logic to block access for disabled administrators.

Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@xh3n1 xh3n1 force-pushed the block-disabled-admins branch from 9ad7af3 to d2c83ae Jun 22, 2018
@samtuke samtuke requested a review from oliverklee Jun 22, 2018
@oliverklee oliverklee merged commit 05d2205 into master Jun 22, 2018
3 checks passed
3 checks passed
Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@oliverklee oliverklee deleted the block-disabled-admins branch Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants