Hardcode doctrine/instantiator 1.0.5 as dependency #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtuke
approved these changes
Jun 21, 2018
|
@xh3n1 Can you rebase and push again? |
There is a known bug in Composer (composer/composer#7388) which makes ``--prefer-lowest` pull in a version incompatible with PHP 7.0. Until this issue is resolved, let's hardcode 1.0.5 as dependency. Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
xh3n1
force-pushed
the
hardcode-instantiator-dependency
branch
from
99c0c34 to
d9285c6
Compare
|
@samtuke Done 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known bug in Composer (composer/composer#7388) which makes ``--prefer-lowest` pull in a version incompatible with PHP 7.0.
Until this issue is resolved, let's hardcode 1.0.5 as dependency.
See also https://travis-ci.org/phpList/core/jobs/395091949 which is working vs. https://travis-ci.org/phpList/core/jobs/395081946 which is not.