Skip to content

Add getNamespaceSeparator() to NameInflector #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add getNamespaceSeparator() to NameInflector #27

wants to merge 2 commits into from

Conversation

przepompownia
Copy link
Contributor

No description provided.

@przepompownia przepompownia mentioned this pull request Apr 12, 2022
Merged
shadowhand
shadowhand reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@shadowhand shadowhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this useful?

@dantleech
Copy link
Collaborator

dantleech commented Aug 12, 2022 •
edited
Loading

Probably because of Legacy_PHP_5_Code ? (?) sorry @przepompownia I think I missed this

@przepompownia
Copy link
Contributor Author

@shadowhand @dantleech plase look at the discussion in #26

This change is a refactor only to avoid duplicate knowledge about namespace separators outside NameInflector implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shadowhand shadowhand shadowhand left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przepompownia @dantleech @shadowhand