[ticket/12580] Remove :link pseudo from a tag

[hanakin]

[ticket/12580] Remove :link pseudo from a tag

removed the :link pseudo from a tag as due to specificity it prevents
classes from altering any properties set to it.

PHPBB3-12580 https://tracker.phpbb.com/browse/PHPBB3-12580?filter=-2

[bantu]

In your commit message, please replace "TICKET-12580" with "PHPBB3-12580" and do not repeat the first line. See https://wiki.phpbb.com/Git#Commit_Messages.

Also, if you link to the tracker ticket, this will be a bit easier for us.

[nickvergessen]

Also, if you link to the tracker ticket, this will be a bit easier for us.

In the PullRequest description, not the commit message ;)

[hanakin]

I updated the pull comment, but im not sure how to change a commit msg other than reverting the commit and making the change and updating? Does this affect the pull request? Would I have to resubmit it?

[n-aleha]

One way to do it, is the following:

• git commit --amend
• force push (--force) the changes after you change the message with the above command

[Crizz0]

How will this affect old browser like "IE8"?

What about "a, a:link"?

[hanakin]

IE 8 is CSS 2.1+ compatible and a:link is a CSS 1.0 ruleset left in from IE 6 compatibility days, so should have no effect but feel free to test it.

[Crizz0]

It is still in CSS2.1: http://www.w3.org/TR/CSS21/selector.html#link-pseudo-classes

[hanakin]

thats a HTML 4.0 spec and we are on 5.0 now. IE 8 is a 4.1 browser and as I previously stated its 2.1 + compatible. IE 7 was the 2.1 release.

The whole thing however is moot because its not nor has it ever been a required attribute! a and a:link are for all intensive purposes identical as far as rendering go. The addition of the :link just adds further specificity to the a tag in order to preserve unvisted link status.

Also do not confuse written spec with actual spec. written is what w3c says actual is what the browsers use. Then their is real which is what we use as front-end developers haha.