Skip to content

[ticket/17383] Fix HELO/EHLO error in email messenger on PHP8 #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2024
Merged

[ticket/17383] Fix HELO/EHLO error in email messenger on PHP8 #6705

merged 2 commits into from
Sep 29, 2024

Conversation

rxu
Copy link
Contributor

@rxu rxu commented Aug 15, 2024 •
edited
Loading

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

PHPBB-17383.

@Noxwizard
Copy link
Member

You may want to check that php_uname isn't returning an empty string as well. That's what's happening here: https://www.phpbb.com/community/viewtopic.php?t=2654074

@marc1706 marc1706 added this to the 3.3.14 milestone Sep 29, 2024
@marc1706 marc1706 merged commit 6db142b into phpbb:3.3.x Sep 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.14
Development

Successfully merging this pull request may close these issues.
3 participants
@rxu @Noxwizard @marc1706