Add basic test for "gettype" function. Check for "unknown type" #76
Conversation
yuklia
force-pushed
the
add-basic-test-for-gettype
branch
from
b62eed8 to
3dadad3
Compare
|
I ... don't know why I approved it twice ... Mondays ... |
There was a problem hiding this comment.
This covers http://gcov.php.net/PHP_HEAD/lcov_html/ext/standard/type.c.gcov.php line 37 👏
| unlink($fileName); | ||
| ?> | ||
|
|
||
| --EXPECTF-- |
There was a problem hiding this comment.
Nit:
| --EXPECTF-- | |
| --EXPECT-- |
There was a problem hiding this comment.
Hello, this one for example, I can also fix when I'll be merging it upstream. Let me know also please if you've spotted anything else...
There was a problem hiding this comment.
@petk Should be RTM after this quick fix.
|
@carusogabriel since PHP-7.2 this one returns |
|
Thank you for the pull request. Since we can't know the status of this pr anymore, I'll be merging the rest of the contributions in a single commit... More info on this soon. |
User Group: Kharkiv PHP