Fix error when no data

jdecool · jdecool · commit 84db344fdf05 · 2021-09-24T23:37:08.000+02:00
diff --git a/src/Controller/DefaultController.php b/src/Controller/DefaultController.php
@@ -5,6 +5,7 @@
 namespace App\Controller;
 
 use App\Repository\LastUpdateRepository;
+use RuntimeException;
 use Symfony\Component\HttpFoundation\Response;
 
 final class DefaultController
@@ -16,7 +17,11 @@ public function __construct(
 
     public function index(): Response
     {
-        $lastUpdate = $this->repository->get()->format('Y-m-d H:i:s');
+        try {
+            $lastUpdate = $this->repository->get()->format('Y-m-d H:i:s');
+        } catch (RuntimeException $e) {
+            $lastUpdate = $e->getMessage();
+        }
 
         return new Response(<<<HTML
 <html>
diff --git a/src/Repository/LastUpdateRepository.php b/src/Repository/LastUpdateRepository.php
@@ -8,6 +8,7 @@
 use DateTimeImmutable;
 use PDO;
 use PDOException;
+use RuntimeException;
 
 final class LastUpdateRepository
 {
@@ -20,8 +21,11 @@ public function __construct(
     public function get(): DateTimeImmutable
     {
         $stmt = $this->db->query('SELECT * FROM last_update;');
+        if (false === ($date = $stmt->fetchColumn())) {
+            throw new RuntimeException('Data has never been updated.');
+        }
 
-        return new DateTimeImmutable($stmt->fetchColumn());
+        return new DateTimeImmutable($date);
     }
 
     public function save(): void

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`use DateTimeImmutable;`
`9`	`9`	`use PDO;`
`10`	`10`	`use PDOException;`
	`11`	`+use RuntimeException;`
`11`	`12`
`12`	`13`	`final class LastUpdateRepository`
`13`	`14`	`{`
`@@ -20,8 +21,11 @@ public function __construct(`
`20`	`21`	`public function get(): DateTimeImmutable`
`21`	`22`	`{`
`22`	`23`	`$stmt = $this->db->query('SELECT * FROM last_update;');`
	`24`	`+ if (false === ($date = $stmt->fetchColumn())) {`
	`25`	`+ throw new RuntimeException('Data has never been updated.');`
	`26`	`+ }`
`23`	`27`
`24`		`- return new DateTimeImmutable($stmt->fetchColumn());`
	`28`	`+ return new DateTimeImmutable($date);`
`25`	`29`	`}`
`26`	`30`
`27`	`31`	`public function save(): void`