New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add configuration for Probot Stale #13380

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
4 participants
@nijel
Member

nijel commented Jun 13, 2017

See https://github.com/probot/stale/

We have quite some pull requests which did not receive attention for quite some time and are not ready to be merged. This enables Probot Stale to label those as wontfix after 60 days and close them after additional 7 days without activity.

I think it's better to having a bot do the work because it, to some degree, is less personal and it can avoid bad feelings from the contributors as it's bureaucracy that closed your pull request.

Add configuration for Probot Stale
See https://github.com/probot/stale/

Signed-off-by: Michal Čihař <michal@cihar.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 13, 2017

Codecov Report

Merging #13380 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13380   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files         467      467           
  Lines       70464    70464           
=======================================
  Hits        38447    38447           
  Misses      32017    32017

codecov bot commented Jun 13, 2017

Codecov Report

Merging #13380 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13380   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files         467      467           
  Lines       70464    70464           
=======================================
  Hits        38447    38447           
  Misses      32017    32017
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jun 14, 2017

Member

I think it's a good option. If there is no activity with these deadlines, it is better to close the PR.

Member

mauriciofauth commented Jun 14, 2017

I think it's a good option. If there is no activity with these deadlines, it is better to close the PR.

@ibennetch

This comment has been minimized.

Show comment
Hide comment
@ibennetch

ibennetch Jun 19, 2017

Member

I somewhat rather disagree; it's easy for us to accidentally ignore a pull request or assume someone else is looking at it; closing such requests automatically may cause us to inadvertently ignore someone's work. However, I do understand that it can be seen as better to be rejected by a bot than a human. I'm not sure I have a better idea, but I'm concerned that automating rejections may cause problems.

Member

ibennetch commented Jun 19, 2017

I somewhat rather disagree; it's easy for us to accidentally ignore a pull request or assume someone else is looking at it; closing such requests automatically may cause us to inadvertently ignore someone's work. However, I do understand that it can be seen as better to be rejected by a bot than a human. I'm not sure I have a better idea, but I'm concerned that automating rejections may cause problems.

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Jun 27, 2017

Member

It first adds comment and if nothing happens for additional week, the issue is closed. The thresholds can be configured.

You can see example interaction here: WeblateOrg/weblate#1128 (comment)

Member

nijel commented Jun 27, 2017

It first adds comment and if nothing happens for additional week, the issue is closed. The thresholds can be configured.

You can see example interaction here: WeblateOrg/weblate#1128 (comment)

@udan11

This comment has been minimized.

Show comment
Hide comment
@udan11

udan11 Jul 8, 2017

Member

I am ok with this.

Member

udan11 commented Jul 8, 2017

I am ok with this.

@nijel nijel merged commit b9a2a7c into phpmyadmin:master Sep 5, 2017

6 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer No new issues
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing c6c7a12...f509d9c
Details
codecov/project 54.56% remains the same compared to c6c7a12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 5, 2017

Member

Merged, I think it is really good to have something pushing on stale pull requests as otherwise they will stay not handled for really long.

Member

nijel commented Sep 5, 2017

Merged, I think it is really good to have something pushing on stale pull requests as otherwise they will stay not handled for really long.

@nijel nijel deleted the nijel:probot-stale branch Sep 5, 2017

@nijel nijel self-assigned this Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment