Skip to content

Conversation

nijel
Copy link
Contributor

@nijel nijel commented Jun 13, 2017

See https://github.com/probot/stale/

We have quite some pull requests which did not receive attention for quite some time and are not ready to be merged. This enables Probot Stale to label those as wontfix after 60 days and close them after additional 7 days without activity.

I think it's better to having a bot do the work because it, to some degree, is less personal and it can avoid bad feelings from the contributors as it's bureaucracy that closed your pull request.

See https://github.com/probot/stale/

Signed-off-by: Michal Čihař <michal@cihar.com>
@codecov
Copy link

codecov bot commented Jun 13, 2017

Codecov Report

Merging #13380 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13380   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files         467      467           
  Lines       70464    70464           
=======================================
  Hits        38447    38447           
  Misses      32017    32017

@MauricioFauth
Copy link
Member

I think it's a good option. If there is no activity with these deadlines, it is better to close the PR.

@ibennetch
Copy link
Member

I somewhat rather disagree; it's easy for us to accidentally ignore a pull request or assume someone else is looking at it; closing such requests automatically may cause us to inadvertently ignore someone's work. However, I do understand that it can be seen as better to be rejected by a bot than a human. I'm not sure I have a better idea, but I'm concerned that automating rejections may cause problems.

@nijel
Copy link
Contributor Author

nijel commented Jun 27, 2017

It first adds comment and if nothing happens for additional week, the issue is closed. The thresholds can be configured.

You can see example interaction here: WeblateOrg/weblate#1128 (comment)

@udan11
Copy link
Contributor

udan11 commented Jul 8, 2017

I am ok with this.

@nijel nijel merged commit b9a2a7c into phpmyadmin:master Sep 5, 2017
@nijel
Copy link
Contributor Author

nijel commented Sep 5, 2017

Merged, I think it is really good to have something pushing on stale pull requests as otherwise they will stay not handled for really long.

@nijel nijel deleted the probot-stale branch September 5, 2017 12:59
@nijel nijel self-assigned this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants