New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch fixed for the datepickerui broken #14199 #14206

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@akshilshah

akshilshah commented Apr 18, 2018

Fixes #14199
It is not a permanent solution but as of now, I could think of this option to make it go.

Implementation:
Removed the scroll frame when clicked on the date picker and add it back as soon as date picker is destroyed.

Signed-off-by: Akshil Shah akshilshah4444@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
fixed the datepickerui broken #14199
Signed-off-by: Akshil Shah <akshilshah4444@gmail.com>

@akshilshah akshilshah changed the title from fixed the datepickerui broken #14199 to patch fixed for the datepickerui broken #14199 Apr 18, 2018

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 19, 2018

I was thinking about changing how the positioning of this element works. or, 'overflow-x' could be removed as suggested by users.

@akshilshah

This comment has been minimized.

akshilshah commented Apr 20, 2018

User was facing problem at the time of datepicker only. so I don't really think there is need to remove overflow as I personally like the responsive table.
this patch will remove overflow particular when the user wants to use datepicker and will add back once it has been done.

@mauriciofauth mauriciofauth self-assigned this Apr 25, 2018

@BePsvPT BePsvPT referenced this pull request Jun 19, 2018

Closed

fix table horizontal scrolling bug #14403

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment