Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch fixed for the datepickerui broken #14199 #14206

Closed
wants to merge 1 commit into from
Closed

patch fixed for the datepickerui broken #14199 #14206

wants to merge 1 commit into from

Conversation

akshilshah
Copy link

Fixes #14199
It is not a permanent solution but as of now, I could think of this option to make it go.

Implementation:
Removed the scroll frame when clicked on the date picker and add it back as soon as date picker is destroyed.

Signed-off-by: Akshil Shah akshilshah4444@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Akshil Shah <akshilshah4444@gmail.com>
@akshilshah akshilshah changed the title fixed the datepickerui broken #14199 patch fixed for the datepickerui broken #14199 Apr 18, 2018
@aroralakshya
Copy link
Contributor

I was thinking about changing how the positioning of this element works. or, 'overflow-x' could be removed as suggested by users.

@akshilshah
Copy link
Author

User was facing problem at the time of datepicker only. so I don't really think there is need to remove overflow as I personally like the responsive table.
this patch will remove overflow particular when the user wants to use datepicker and will add back once it has been done.

@MauricioFauth MauricioFauth self-assigned this Apr 25, 2018
@bepsvpt bepsvpt mentioned this pull request Jun 19, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Issue - date picker hides in scroll frame
3 participants