Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExtension removal #14317
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 22, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14317 +/- ##
============================================
- Coverage 50.45% 50.43% -0.03%
- Complexity 14410 14428 +18
============================================
Files 502 502
Lines 67019 67042 +23
============================================
- Hits 33814 33811 -3
- Misses 33205 33231 +26 |
laps15
force-pushed the
laps15:extension_removal
branch
3 times, most recently
from
5ddd3e3
to
f46a453
May 22, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 23, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14317 +/- ##
============================================
- Coverage 51.1% 51% -0.11%
- Complexity 14413 14444 +31
============================================
Files 501 500 -1
Lines 66180 66242 +62
============================================
- Hits 33823 33788 -35
- Misses 32357 32454 +97 |
laps15
force-pushed the
laps15:extension_removal
branch
2 times, most recently
from
76ae1df
to
34aa034
May 28, 2018
mauriciofauth
reviewed
May 28, 2018
browse_foreigners.php
Outdated
| isset($fieldkey) ? $fieldkey : null, | ||
| isset($data) ? $data : null | ||
| isset($fieldkey) ? $fieldkey : (string)null, | ||
| isset($data) ? $data : (string)null |
This comment has been minimized.
This comment has been minimized.
| 'databases' => isset($databases) ? $databases : null, | ||
| 'dbi' => $this->dbi, | ||
| 'dbi' => $GLOBALS['dbi'], |
This comment has been minimized.
This comment has been minimized.
mauriciofauth
May 28, 2018
Member
It seems to me that you are reverting the dce862d changes. Is this intentional?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
laps15
May 28, 2018
Author
Contributor
It probably was a rebase with the master branch that placed my changes over yours. Sorry.
laps15
force-pushed the
laps15:extension_removal
branch
3 times, most recently
from
27f3617
to
4222cfa
May 28, 2018
laps15
force-pushed the
laps15:extension_removal
branch
from
4222cfa
to
5d0fd81
May 30, 2018
mauriciofauth
merged commit 0665674
into
phpmyadmin:master
May 30, 2018
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks for your contribution! |
mauriciofauth
added this to the 5.0.0 milestone
May 30, 2018
mauriciofauth
self-assigned this
May 30, 2018
laps15
deleted the
laps15:extension_removal
branch
May 31, 2018
dhyey35
referenced this pull request
Dec 22, 2018
Merged
Fix #14756: Browser display transformation selection #14810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
laps15 commentedMay 22, 2018
Before submitting pull request, please check that every commit: