Extension removal #14317
Merged
Extension removal #14317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14317 +/- ##
============================================
- Coverage 50.45% 50.43% -0.03%
- Complexity 14410 14428 +18
============================================
Files 502 502
Lines 67019 67042 +23
============================================
- Hits 33814 33811 -3
- Misses 33205 33231 +26 |
laps15
force-pushed
the
extension_removal
branch
3 times, most recently
from
5ddd3e3 to
f46a453
Compare
Codecov Report
@@ Coverage Diff @@
## master #14317 +/- ##
============================================
- Coverage 51.1% 51% -0.11%
- Complexity 14413 14444 +31
============================================
Files 501 500 -1
Lines 66180 66242 +62
============================================
- Hits 33823 33788 -35
- Misses 32357 32454 +97 |
laps15
force-pushed
the
extension_removal
branch
2 times, most recently
from
76ae1df to
34aa034
Compare
browse_foreigners.php
Outdated
| isset($fieldkey) ? $fieldkey : null, | ||
| isset($data) ? $data : null | ||
| isset($fieldkey) ? $fieldkey : (string)null, | ||
| isset($data) ? $data : (string)null |
There was a problem hiding this comment.
Wouldn't it be better to use an empty string?
| 'databases' => isset($databases) ? $databases : null, | ||
| 'dbi' => $this->dbi, | ||
| 'dbi' => $GLOBALS['dbi'], |
There was a problem hiding this comment.
It seems to me that you are reverting the dce862d changes. Is this intentional?
There was a problem hiding this comment.
No ideia why this hapenned. I'm trying to fix it.
There was a problem hiding this comment.
It probably was a rebase with the master branch that placed my changes over yours. Sorry.
laps15
force-pushed
the
extension_removal
branch
3 times, most recently
from
27f3617 to
4222cfa
Compare
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
|
Merged, thanks for your contribution! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request, please check that every commit: