Fix broken incorrect clause order detection for Joins #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
|
Hi @nijel I am unable to comprehend the error in the travis build and its actual source from the commit ? Plus it fails only on hhvm. |
|
The hhvm builds fail since some hhvm update, I haven't yet found time to look at it... |
nijel
added a commit
that referenced
this pull request
Nov 15, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #22 by #96 lead to this breaking. It gives incorrect messages even if the query and the clauses are in right order.
This PR should remove that incorrect message.