Fix #105: Fix parsing of FIELDS and LINES options in Select..Into #107

Merged
merged 5 commits into from Dec 22, 2016

Projects

None yet

3 participants

@devenbansod
Member

Fix #105

Add parsing for previously unimplemented options.

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

devenbansod added some commits Dec 21, 2016
@devenbansod devenbansod Fix parsing of FIELDS and LINES options in SELECT..INTO
Fix #105

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
f23527c
@devenbansod devenbansod Add tests for parsing of FIELDS and LINES options in SELECT..INTO
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
8d3ffed
@devenbansod devenbansod Add more tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
403f585
@codecov-io
codecov-io commented Dec 21, 2016 edited

Current coverage is 99.73% (diff: 100%)

Merging #107 into master will increase coverage by <.01%

@@             master       #107   diff @@
==========================================
  Files            53         53          
  Lines          3706       3738    +32   
  Methods         179        180     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3696       3728    +32   
  Misses           10         10          
  Partials          0          0          

Powered by Codecov. Last update abfdf58...54970a2

devenbansod added some commits Dec 21, 2016
@devenbansod devenbansod Add more tests, fix unneeded error
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
62ca07c
@devenbansod devenbansod Make the method access public since called from object
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
54970a2
@nijel nijel self-assigned this Dec 22, 2016
@nijel nijel merged commit a59b441 into phpmyadmin:master Dec 22, 2016

4 checks passed

codacy/pr Good work! A positive pull request.
Details
codecov/patch 100% of diff hit (target 99.73%)
Details
codecov/project 99.73% (+<.01%) compared to abfdf58
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel nijel added a commit that referenced this pull request Dec 22, 2016
@nijel nijel Document change for #105 and #107
Signed-off-by: Michal Čihař <michal@cihar.com>
246b123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment