Made motranslator vendor optional #132

Merged
merged 2 commits into from Feb 2, 2017

Projects

None yet

3 participants

@bigfoot90
Contributor

Suggest installing phpmyadmin/mostranslator instead of requiring it.

Close #129

@bigfoot90 bigfoot90 Made motranslator vendor optional
ff12d2e
@codecov-io
codecov-io commented Feb 1, 2017 edited

Codecov Report

Merging #132 into master will increase coverage by -0.03%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   99.86%   99.84%   -0.03%     
==========================================
  Files          54       54              
  Lines        3785     3787       +2     
==========================================
+ Hits         3780     3781       +1     
- Misses          5        6       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f39f9...d2ae6c9. Read the comment docs.

@bigfoot90 bigfoot90 require-dev phpmyadmin/motranslator
d2ae6c9
@nijel nijel self-assigned this Feb 2, 2017
@nijel nijel merged commit f502863 into phpmyadmin:master Feb 2, 2017

2 of 4 checks passed

codecov/patch 50% of diff hit (target 99.86%)
Details
codecov/project 99.84% (-0.03%) compared to 59f39f9
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel
Member
nijel commented Feb 2, 2017

Merged, thanks for your contribution!

@nijel nijel added a commit that referenced this pull request Feb 2, 2017
@nijel nijel Changelog for #129 and #132
Signed-off-by: Michal Čihař <michal@cihar.com>
e042cb0
@nijel nijel added a commit that referenced this pull request Feb 2, 2017
@nijel nijel Make motranslator optional for dev as well and test both cases
This way we can ensure that we don't break our code with or without
motranslator.

Issue #129, #132

Signed-off-by: Michal Čihař <michal@cihar.com>
7f594b2
@bigfoot90 bigfoot90 deleted the bigfoot90:suggest-motranslator branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment