Add support for CHECK Constraints #200
Conversation
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
============================================
- Coverage 99.77% 97.23% -2.54%
+ Complexity 1841 1794 -47
============================================
Files 61 58 -3
Lines 4388 4234 -154
============================================
- Hits 4378 4117 -261
- Misses 10 117 +107 |
aroralakshya
force-pushed
the
check_constraints
branch
2 times, most recently
from
a52cdbd to
f6946f7
Compare
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi @nulll-pointer thanks for the PR. Could you please fix the breaking test? And also, please add tests to cover this new syntax. |
| /** | ||
| * The operands in this component. | ||
| * | ||
| * @var operands |
There was a problem hiding this comment.
Should it be @var array? Not sure what @var operands would mean here.
| * | ||
| * @var logicalOperatorsArray | ||
| */ | ||
| public $logicalOperators; |
There was a problem hiding this comment.
We seem to be using _ to separate out words in variables (and not use camelCase). Can you please change that.
|
@nulll-pointer Can you please update the PR ? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| * | ||
| * @var OperatorsArray | ||
| */ | ||
| public static $operatorsArray = array("=", ">", "<", "<=", ">=", "!=", "LIKE", "NOT", "BETWEEN", "IS", "NULL", "REGEXP", "REGEXP"); |
There was a problem hiding this comment.
REGEXP duplicated value in array
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I do not like to have to close this PR, but I have to. |
|
But still, thank you @aroralakshya ! |
Add support for CHECK Constraints
#167
Signed-Off-By: Lakshay arora arora.lakshya123@gmail.com