Skip to content

Move to GitHub actions #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Move to GitHub actions #324

merged 3 commits into from
Jan 10, 2021

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #324 (b4ce6bc) into QA (278bb29) will decrease coverage by 4.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                 QA     #324      +/-   ##
============================================
- Coverage     99.71%   95.69%   -4.03%     
- Complexity     1911     1971      +60     
============================================
  Files            63       65       +2     
  Lines          4601     4392     -209     
============================================
- Hits           4588     4203     -385     
- Misses           13      189     +176     
Flag Coverage Δ Complexity Δ
motranslator 95.71% <ø> (?) 0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Component.php 100.00% <ø> (ø) 3.00 <0.00> (ø)
src/Components/AlterOperation.php 100.00% <ø> (ø) 35.00 <0.00> (ø)
src/Components/Array2d.php 100.00% <ø> (ø) 15.00 <0.00> (ø)
src/Components/ArrayObj.php 100.00% <ø> (ø) 26.00 <0.00> (ø)
src/Components/CaseExpression.php 100.00% <ø> (ø) 52.00 <0.00> (ø)
src/Components/Condition.php 100.00% <ø> (ø) 29.00 <0.00> (ø)
src/Components/CreateDefinition.php 100.00% <ø> (ø) 43.00 <0.00> (ø)
src/Components/DataType.php 100.00% <ø> (ø) 17.00 <0.00> (ø)
src/Components/Expression.php 100.00% <ø> (ø) 90.00 <0.00> (ø)
src/Components/ExpressionArray.php 95.74% <ø> (-0.34%) 23.00 <0.00> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278bb29...e40bab2. Read the comment docs.

@williamdes
Copy link
Member

Thanks for adding 8.0 to the build matrix
We already support 8.0:

"php": "^7.1 || ^8.0",

@staabm staabm changed the title Add php8 support Add php8 travis build Jan 10, 2021
@staabm
Copy link
Contributor Author

staabm commented Jan 10, 2021

Ohh I thought I need to fix #315 ?

@williamdes
Copy link
Member

Ohh I thought I need to fix #315 ?

Oh, sure
I had forgot about that, well I would say we support php 8 but there is a bug somewhere for php 8.0

You can continue then, thank you ;)

@staabm staabm marked this pull request as ready for review January 10, 2021 16:13
@staabm
Copy link
Contributor Author

staabm commented Jan 10, 2021

Hm #315 seems no longer be reproducible. Maybe it was a bug in a php8 RC release or in one of the dependencies (in phpunit itself?).

the error does not show up in the travis build, so this seems to be ready to land

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes changed the title Add php8 travis build Move to GitHub actions Jan 10, 2021
@williamdes williamdes self-assigned this Jan 10, 2021
@williamdes
Copy link
Member

I edited this PR to move to GHA
And when I will merge it I will add php 8.0 for master branch

@williamdes williamdes added this to the 4.7.2 milestone Jan 10, 2021
@williamdes williamdes merged commit ca8d5f3 into phpmyadmin:QA Jan 10, 2021
@williamdes
Copy link
Member

williamdes commented Jan 10, 2021

I added your fix in 0fb1da6

Thank you !

@staabm
Copy link
Contributor Author

staabm commented Jan 10, 2021

Cool thx.

Any eta for a next release, so we can build bew releases on top of the added php8 support?

@williamdes
Copy link
Member

Cool thx.

Any eta for a next release, so we can build bew releases on top of the added php8 support?

cc @ibennetch
For me the next version is ready to be released, on QA also.

@staabm staabm deleted the patch-1 branch January 10, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants