Use motranslator for translating

[nijel]

This makes it work transparently with or without phpMyAdmin.

See also phpmyadmin/phpmyadmin#12023

Signed-off-by: Michal Čihař michal@cihar.com

[codecov-io]

Current coverage is 99.17%

Merging #35 into master will increase coverage by +0.01% as of 10ac2b3

@@            master     #35   diff @@
======================================
  Files           48      49     +1
  Stmts         3481    3497    +16
  Branches         0       0       
  Methods        158     161     +3
======================================
+ Hit           3452    3468    +16
  Partial          0       0       
  Missed          29      29       

Review entire Coverage Diff as of 10ac2b3

Powered by Codecov. Updated on successful CI builds.

[nisargjhaveri]

Can't we make gettext a static method and use Translator::gettext($msg) instead of Translator::getInstance()->gettext($msg). Looks much cleaner and easier to use.

[nijel]

Indeed that would be doable as well with lazy initialization of the translator (we don't need it in most cases, it's used only for errors).

[nijel]

Thinking more about this I'm not sure if it's good idea to include this in releases used in phpMyAdmin 4.6.x as this will bring two gettext implementation into phpMyAdmin codebase....

[nisargjhaveri]

If we want to think really 'modular', it shouldn't matter :P . But yes, makes sense.

How are we actually managing releases of SQL parser?

[nijel]

It won't matter for 4.7, but for 4.6 I'm not sure if switching phpmyadmin to motranslator is reasonable...

[nisargjhaveri]

Agreed.

[nijel]

Superseded by #106