Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the EXPLAIN Parser #389

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Nov 24, 2022

Hi, This PR is adding and supporting the EXPLAIN Statements with all its variations for MariaDB and MySQL.
Following up on phpmyadmin/phpmyadmin#17482 (comment), and resolving phpmyadmin/phpmyadmin#11867.

Signed-off-by: iifawzi iifawzie@gmail.com

Signed-off-by: iifawzi <iifawzie@gmail.com>
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 95.64% // Head: 95.60% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (5689daf) compared to base (8fddb4b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #389      +/-   ##
============================================
- Coverage     95.64%   95.60%   -0.05%     
- Complexity     2144     2173      +29     
============================================
  Files            67       68       +1     
  Lines          4548     4616      +68     
============================================
+ Hits           4350     4413      +63     
- Misses          198      203       +5     
Impacted Files Coverage Δ
src/Statements/ExplainStatement.php 100.00% <100.00%> (ø)
src/Statements/NotImplementedStatement.php 50.00% <0.00%> (-50.00%) ⬇️
src/Utils/Query.php 98.94% <0.00%> (ø)
src/Statements/SelectStatement.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good

williamdes added a commit that referenced this pull request Nov 25, 2022
Pull-request: #389

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 158de19 into phpmyadmin:master Nov 25, 2022
@williamdes
Copy link
Member

Thank you for your continuous work and contributions on this parser ! 🚀

@williamdes williamdes self-assigned this Nov 25, 2022
@williamdes williamdes added this to the 5.6.0 milestone Nov 25, 2022
@williamdes
Copy link
Member

Fixed a typo -> c4d58c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants