Skip to content

Conversation

@williamdes
Copy link
Member

Fixes: #445 - re-design part of DESCRIBE

@williamdes williamdes added this to the 5.8.0 milestone May 9, 2023
williamdes added 2 commits May 9, 2023 11:49
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member Author

Hi @iifawzi
I did some re-design on top of #389, would you mind having a look to my changes ?

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (be57b5c) 97.00% compared to head (1420af7) 97.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.8.x     #446      +/-   ##
============================================
+ Coverage     97.00%   97.02%   +0.01%     
- Complexity     2219     2234      +15     
============================================
  Files            69       69              
  Lines          5111     5144      +33     
============================================
+ Hits           4958     4991      +33     
  Misses          153      153              
Impacted Files Coverage Δ
src/Statements/ExplainStatement.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iifawzi
Copy link
Contributor

iifawzi commented May 13, 2023

Hi, sorry for the late replies, I've been away for a while, will take a look asap

@williamdes
Copy link
Member Author

@niconoe- this PR should be the last thing to be merged for rc1
What do you think about it ?

@niconoe-
Copy link
Contributor

@williamdes Seems nice to me! 👍

@williamdes williamdes self-assigned this May 29, 2023
williamdes added a commit that referenced this pull request May 29, 2023
Pull-request: #446

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 59a8c8b into phpmyadmin:5.8.x May 29, 2023
@williamdes williamdes deleted the fix-describe branch May 29, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants