-
-
Notifications
You must be signed in to change notification settings - Fork 109
Fix #377 - PARTITION syntax errors #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #423 +/- ##
=========================================
Coverage 97.05% 97.05%
- Complexity 2213 2217 +4
=========================================
Files 69 69
Lines 5092 5102 +10
=========================================
+ Hits 4942 4952 +10
Misses 150 150
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I am un sure about the whitespace skipping. @iifawzi what do you think?
Whitespaces are not skipped actually. The usage of
|
Signed-off-by: William Desportes <williamdes@wdes.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I think something is missing for CREATE TABLE
Pull-request: #423 Signed-off-by: William Desportes <williamdes@wdes.fr>
First commit contains the fix proposal, a new
.in
file about the partition by range, and a new.out
file that was generated with currentmaster
status.The second commit contains the update of the
.out
file regarding the changes brought to fix #377From what I analyzed, the issue of #377 is that the PARTITION BY RANGE is not understood correctly by the parser as all partitions were written in the
field
property of the AlterOperation, which caused the syntax error on the linter on PhpMyAdmin. With this fix, the partitions are better managed in thepartitions
property of the AlterOperation, causing no issue with the linter.Fixes: #377