Fix parsing of INSERT...SELECT and INSERT...SET syntax #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement separate parse function for InsertStatement Fix phpmyadmin#50 Fix phpmyadmin#73 Fix phpmyadmin/phpmyadmin#11628 Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Current coverage is 96.98% (diff: 85.71%)@@ master #76 diff @@
==========================================
Files 49 49
Lines 3145 3219 +74
Methods 165 166 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 3059 3122 +63
- Misses 86 97 +11
Partials 0 0
|
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
|
Good, only test coverage could be better ;-). (see https://codecov.io/gh/phpmyadmin/sql-parser/compare/bd8936d2d6d1b932211a29cea313749be13bac83...7e6fbf70c33e0320fee040f596aa788cb3135805) |
nijel
added a commit
that referenced
this pull request
Sep 13, 2016
Issue #76 Signed-off-by: Michal Čihař <michal@cihar.com>
nijel
added a commit
that referenced
this pull request
Sep 13, 2016
Issue #76 Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement separate parse function for InsertStatement
Fix #50
Fix #73
Fix phpmyadmin/phpmyadmin#11628
Signed-off-by: Deven Bansod devenbansod.bits@gmail.com