Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing and building for Delete Statement #87

Merged
merged 4 commits into from Oct 3, 2016

Conversation

@devenbansod
Copy link
Member

devenbansod commented Sep 24, 2016

Implement parsing and building for Delete Statement

Partially fixes phpmyadmin/phpmyadmin#11740

@devenbansod devenbansod force-pushed the devenbansod:delete_statement branch from f84f60a to 0fb198f Sep 24, 2016
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 24, 2016

Current coverage is 99.42% (diff: 100%)

Merging #87 into master will increase coverage by 0.02%

@@             master        #87   diff @@
==========================================
  Files            51         52     +1   
  Lines          3337       3472   +135   
  Methods         171        173     +2   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3317       3452   +135   
  Misses           20         20          
  Partials          0          0          

Powered by Codecov. Last update c66456f...98679cb

devenbansod added 3 commits Sep 24, 2016
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod

This comment has been minimized.

Copy link
Member Author

devenbansod commented Sep 24, 2016

Some more test cases needed. Will add them soon.

@devenbansod devenbansod force-pushed the devenbansod:delete_statement branch 4 times, most recently from 3eb6aa2 to 98679cb Sep 26, 2016
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod

This comment has been minimized.

Copy link
Member Author

devenbansod commented Sep 27, 2016

This too seems ready to tested and hopefully merged.

@nijel nijel self-assigned this Oct 3, 2016
@nijel nijel merged commit 29a9dc1 into phpmyadmin:master Oct 3, 2016
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 99.40%)
Details
codecov/project 99.42% (+0.02%) compared to c66456f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
nijel added a commit that referenced this pull request Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.