Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing of CASE Expressions #88

Merged
merged 5 commits into from Oct 3, 2016
Merged

Conversation

@devenbansod
Copy link
Member

devenbansod commented Sep 25, 2016

Fix phpmyadmin/phpmyadmin#12100.
Also see my comment at phpmyadmin/phpmyadmin#12100 (comment)

Tests to be added.

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

Fix phpmyadmin/phpmyadmin#12100

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 25, 2016

Current coverage is 99.42% (diff: 100%)

Merging #88 into master will increase coverage by 0.02%

@@             master        #88   diff @@
==========================================
  Files            51         52     +1   
  Lines          3337       3456   +119   
  Methods         171        174     +3   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3317       3436   +119   
  Misses           20         20          
  Partials          0          0          

Powered by Codecov. Last update c66456f...f151567

devenbansod added 3 commits Sep 26, 2016
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod devenbansod force-pushed the devenbansod:fix_pma_12100 branch 3 times, most recently from 46bfa6f to f151567 Sep 26, 2016
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod

This comment has been minimized.

Copy link
Member Author

devenbansod commented Sep 27, 2016

This seems ready to tested and hopefully merged.

@nijel nijel self-assigned this Oct 3, 2016
@nijel nijel merged commit 2608760 into phpmyadmin:master Oct 3, 2016
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 99.40%)
Details
codecov/project 99.42% (+0.02%) compared to c66456f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Copy link
Member

nijel commented Oct 3, 2016

Indeed it looks good!

nijel added a commit that referenced this pull request Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this pull request Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Copy link
Member

nijel commented Oct 3, 2016

I've added changelog entry (in e2144e7) and adjusted license header (in 1b72bd3).

@devenbansod devenbansod deleted the devenbansod:fix_pma_12100 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.