Fix #93 : Fix parsing of NATURAL JOIN, CROSS JOIN and related joins #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix phpmyadmin#93 Add tests to cover parsing of these joins Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Current coverage is 99.47% (diff: 100%)@@ master #95 diff @@
==========================================
Files 53 53
Lines 3614 3622 +8
Methods 176 176
Messages 0 0
Branches 0 0
==========================================
+ Hits 3595 3603 +8
Misses 19 19
Partials 0 0
|
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
|
Thanks, looks great! |
nijel
added a commit
that referenced
this pull request
Oct 25, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of NATURAL JOIN, CROSS JOIN and related joins
Fix broken parsing of multiple JOINS in a single query.
Fix #93
Add tests to cover parsing of these joins.
Signed-off-by: Deven Bansod devenbansod.bits@gmail.com