fix: add deprecation for inline validation - should use formRquests instead

Author: phpsa

src/Http/Api/Contracts/HasBatchActions.php

@@ -193,11 +193,17 @@ protected function handleBatchStoreOrUpdateResponse(Collection $items)
         return $this->respondWithResource($this->getResourceCollection(), $items, 200);
     }
 
+    /**
+     * @deprecated use your FormRequest instead
+     */
     protected function rulesForBatchCreate(): array
     {
         return [];
     }
 
+    /**
+     * @deprecated use your FormRequest instead
+     */
     protected function rulesForBatchUpdate(): array
     {
         return [];

src/Http/Api/Contracts/HasResponse.php

@@ -30,7 +30,7 @@ public function setStatusCode(int $statusCode): self
      */
     protected function respondWithOne($item, ?int $code = null, array $headers = [])
     {
-        return $this->respondWithResource($this->/** @scrutinizer ignore-call */getResourceSingle(), $item, $code, $headers);
+        return $this->respondWithResource($this->getResourceSingle(), $item, $code, $headers);
     }
 
     /**
@@ -44,7 +44,7 @@ protected function respondWithOne($item, ?int $code = null, array $headers = [])
      */
     protected function respondWithMany($items, $code = null, $headers = [])
     {
-        return $this->respondWithResource($this->/** @scrutinizer ignore-call */getResourceCollection(), $items, $code, $headers);
+        return $this->respondWithResource($this->getResourceCollection(), $items, $code, $headers);
     }
 
     /**

src/Http/Api/Contracts/HasValidation.php

@@ -2,16 +2,15 @@
 
 namespace Phpsa\LaravelApiController\Http\Api\Contracts;
 
-
 use Phpsa\LaravelApiController\Exceptions\ApiException;
 
-
 trait HasValidation
 {
 
     /**
      * Get the validation rules for create.
      *
+     * @deprecated use FormRequest instead
      * @return array
      */
     protected function rulesForCreate(): array
@@ -22,11 +21,11 @@ protected function rulesForCreate(): array
     /**
      * Get the validation rules for update.
      *
-     * @param int $id
-     *
+     * @param int|string $id
+     * @depreacted use FormRquest instead
      * @return array
      */
-    protected function rulesForUpdate(/* @scrutinizer ignore-unused */$id): array
+    protected function rulesForUpdate($id): array
     {
         return [];
     }