Version 1.6 removes endlines

[TomasVotruba]

Our CI started to crash with removed endlines:
deprecated-packages/symplify@3623019

Any ideas what is causing it and how to fix it?

[ondrejmirtes]

/cc @rvanvelzen

[ondrejmirtes]

Looks like PhpDocNode::__toString() doesn't return the same values as before, or something like that...

[rvanvelzen]

How can I reproduce this failure?

[ondrejmirtes]

I agree, this bug report isn't really useful, we don't know what you're doing with the AST in your application :) So please provide some short snippet with the manipulation you're doing and that leads to different results between 1.5.x and 1.6.0. Thanks.

[TomasVotruba]

I'll see what I can do :). I just wanted to see the commit that could help us detect miss behavior in Rector

[ondrejmirtes]

There's not that many commits, you can bisect that :)

[TomasVotruba]

Good idea, I'll try to lock it

[TomasVotruba]

This is the first commit that breaks: 7c621a2

[ondrejmirtes]

I tried to reproduce it with no luck: 07c49b0

The test passes even on 1.5.1.

[TomasVotruba]

Probably just autoload race condition.
New PHPStan release with this package should fix it :)

For now, we've added preload.php workaround:
7c621a2#r75701518

[TomasVotruba]

It will break anyone using older Rector, as it loads PHPStan's TokenIterator, but there is nothing we can do about it now.

[ondrejmirtes]

Done: https://github.com/phpstan/phpstan/releases/tag/1.7.12

[TomasVotruba]

I'll try it, thanks 👍