Disallow named arguments on PHP < 8.0

Author: ondrejmirtes

src/Php/PhpVersion.php

@@ -91,4 +91,9 @@ public function supportsUnsetCast(): bool
 		return $this->versionId < 80000;
 	}
 
+	public function supportsNamedArguments(): bool
+	{
+		return $this->versionId >= 80000;
+	}
+
 }

src/Rules/FunctionCallParametersCheck.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\Scope;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\NeverType;
@@ -20,6 +21,8 @@ class FunctionCallParametersCheck
 
 	private NullsafeCheck $nullsafeCheck;
 
+	private PhpVersion $phpVersion;
+
 	private bool $checkArgumentTypes;
 
 	private bool $checkArgumentsPassedByReference;
@@ -31,6 +34,7 @@ class FunctionCallParametersCheck
 	public function __construct(
 		RuleLevelHelper $ruleLevelHelper,
 		NullsafeCheck $nullsafeCheck,
+		PhpVersion $phpVersion,
 		bool $checkArgumentTypes,
 		bool $checkArgumentsPassedByReference,
 		bool $checkExtraArguments,
@@ -39,6 +43,7 @@ public function __construct(
 	{
 		$this->ruleLevelHelper = $ruleLevelHelper;
 		$this->nullsafeCheck = $nullsafeCheck;
+		$this->phpVersion = $phpVersion;
 		$this->checkArgumentTypes = $checkArgumentTypes;
 		$this->checkArgumentsPassedByReference = $checkArgumentsPassedByReference;
 		$this->checkExtraArguments = $checkExtraArguments;
@@ -77,8 +82,12 @@ public function check(
 		$arguments = [];
 		/** @var array<int, \PhpParser\Node\Arg> $args */
 		$args = $funcCall->args;
+		$hasNamedArguments = false;
 		foreach ($args as $i => $arg) {
 			$type = $scope->getType($arg->value);
+			if ($arg->name !== null) {
+				$hasNamedArguments = true;
+			}
 			if ($arg->unpack) {
 				$arrays = TypeUtils::getConstantArrays($type);
 				if (count($arrays) > 0) {
@@ -121,6 +130,11 @@ public function check(
 		}
 
 		$errors = [];
+
+		if ($hasNamedArguments && !$this->phpVersion->supportsNamedArguments()) {
+			$errors[] = RuleErrorBuilder::message('Named arguments are supported only on PHP 8.0 and later.')->nonIgnorable()->build();
+		}
+
 		$invokedParametersCount = count($arguments);
 		foreach ($arguments as $i => [$argumentValue, $argumentValueType, $unpack]) {
 			if ($unpack) {

tests/PHPStan/Rules/Classes/InstantiationRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Classes;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\ClassCaseSensitivityCheck;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\NullsafeCheck;
@@ -18,7 +19,7 @@ protected function getRule(): \PHPStan\Rules\Rule
 		$broker = $this->createReflectionProvider();
 		return new InstantiationRule(
 			$broker,
-			new FunctionCallParametersCheck(new RuleLevelHelper($broker, true, false, true, false), new NullsafeCheck(), true, true, true, true),
+			new FunctionCallParametersCheck(new RuleLevelHelper($broker, true, false, true, false), new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), true, true, true, true),
 			new ClassCaseSensitivityCheck($broker)
 		);
 	}

tests/PHPStan/Rules/Functions/CallCallablesRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Functions;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\NullsafeCheck;
 use PHPStan\Rules\RuleLevelHelper;
@@ -19,6 +20,7 @@ protected function getRule(): \PHPStan\Rules\Rule
 			new FunctionCallParametersCheck(
 				$ruleLevelHelper,
 				new NullsafeCheck(),
+				new PhpVersion(PHP_VERSION_ID),
 				true,
 				true,
 				true,

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Functions;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\NullsafeCheck;
 use PHPStan\Rules\RuleLevelHelper;
@@ -17,7 +18,7 @@ protected function getRule(): \PHPStan\Rules\Rule
 		$broker = $this->createReflectionProvider();
 		return new CallToFunctionParametersRule(
 			$broker,
-			new FunctionCallParametersCheck(new RuleLevelHelper($broker, true, false, true, false), new NullsafeCheck(), true, true, true, true)
+			new FunctionCallParametersCheck(new RuleLevelHelper($broker, true, false, true, false), new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), true, true, true, true)
 		);
 	}
 

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Methods;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\NullsafeCheck;
 use PHPStan\Rules\Rule;
@@ -32,7 +33,7 @@ protected function getRule(): Rule
 		$ruleLevelHelper = new RuleLevelHelper($broker, $this->checkNullables, $this->checkThisOnly, $this->checkUnionTypes, $this->checkExplicitMixed);
 		return new CallMethodsRule(
 			$broker,
-			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), true, true, true, true),
+			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), true, true, true, true),
 			$ruleLevelHelper,
 			true,
 			true
@@ -1579,4 +1580,25 @@ public function testNullSafe(): void
 		]);
 	}
 
+	public function testDisallowNamedArguments(): void
+	{
+		if (PHP_VERSION_ID >= 80000) {
+			$this->markTestSkipped('Test requires PHP earlier than 8.0.');
+		}
+		if (!self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires static reflection.');
+		}
+
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+
+		$this->analyse([__DIR__ . '/data/disallow-named-arguments.php'], [
+			[
+				'Named arguments are supported only on PHP 8.0 and later.',
+				10,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Methods;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\ClassCaseSensitivityCheck;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\NullsafeCheck;
@@ -22,7 +23,7 @@ protected function getRule(): \PHPStan\Rules\Rule
 		$ruleLevelHelper = new RuleLevelHelper($broker, true, $this->checkThisOnly, true, false);
 		return new CallStaticMethodsRule(
 			$broker,
-			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), true, true, true, true),
+			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), true, true, true, true),
 			$ruleLevelHelper,
 			new ClassCaseSensitivityCheck($broker),
 			true,

tests/PHPStan/Rules/Methods/data/disallow-named-arguments.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace DisallowNamedArguments;
+
+class Foo
+{
+
+	public function doFoo(): void
+	{
+		$this->doBar(i: 1);
+	}
+
+	public function doBar(int $i): void
+	{
+
+	}
+
+}