Void

Author: VincentLanglet

src/Analyser/NodeScopeResolver.php

@@ -6996,7 +6996,15 @@ public function getPhpDocs(Scope $scope, Node\FunctionLike|Node\Stmt\Property $n
 		if ($isPure === null && $scope->isInClass()) {
 			$classResolvedPhpDoc = $scope->getClassReflection()->getResolvedPhpDoc();
 			if ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsPure()) {
-				$isPure = true;
+				if (
+					strtolower($functionName ?? '') === '__construct'
+					|| (
+						($phpDocReturnType === null || !$phpDocReturnType->isVoid()->yes())
+						&& !$scope->getFunctionType($node->getReturnType(), false, false)->isVoid()->yes()
+					)
+				) {
+					$isPure = true;
+				}
 			} elseif ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsImpure()) {
 				$isPure = false;
 			}

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -897,7 +897,15 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 		if ($isPure === null) {
 			$classResolvedPhpDoc = $phpDocBlockClassReflection->getResolvedPhpDoc();
 			if ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsPure()) {
-				$isPure = true;
+				if (
+					strtolower($methodReflection->getName()) === '__construct'
+					|| (
+						($phpDocReturnType === null || !$phpDocReturnType->isVoid()->yes())
+						&& !$nativeReturnType->isVoid()->yes()
+					)
+				) {
+					$isPure = true;
+				}
 			} elseif ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsImpure()) {
 				$isPure = false;
 			}

tests/PHPStan/Rules/Pure/PureMethodRuleTest.php

@@ -221,44 +221,52 @@ public function testAllMethodsArePure(): void
 		$this->treatPhpDocTypesAsCertain = true;
 		$this->analyse([__DIR__ . '/data/all-methods-are-pure.php'], [
 			[
-				'Method AllMethodsArePure\Foo::test() is marked as pure but returns void.',
-				10,
+				'Method AllMethodsArePure\Foo::pureVoid() is marked as pure but returns void.',
+				30,
 			],
 			[
-				'Method AllMethodsArePure\Foo::pure() is marked as pure but returns void.',
-				17,
+				'Method AllMethodsArePure\Foo::impure() is marked as impure but does not have any side effects.',
+				37,
 			],
 			[
-				'Method AllMethodsArePure\Foo::impure() is marked as impure but does not have any side effects.',
-				24,
+				'Method AllMethodsArePure\Foo::impureVoid() is marked as impure but does not have any side effects.',
+				45,
 			],
 			[
 				'Method AllMethodsArePure\Bar::test() is marked as impure but does not have any side effects.',
-				34,
+				55,
 			],
 			[
-				'Method AllMethodsArePure\Bar::pure() is marked as pure but returns void.',
-				41,
+				'Method AllMethodsArePure\Bar::testVoid() is marked as impure but does not have any side effects.',
+				60,
+			],
+			[
+				'Method AllMethodsArePure\Bar::pureVoid() is marked as pure but returns void.',
+				75,
 			],
 			[
 				'Method AllMethodsArePure\Bar::impure() is marked as impure but does not have any side effects.',
-				48,
+				82,
+			],
+			[
+				'Method AllMethodsArePure\Bar::impureVoid() is marked as impure but does not have any side effects.',
+				90,
 			],
 			[
 				'Impure call to method AllMethodsArePure\Test::impure() in pure method AllMethodsArePure\SideEffectPure::nothingWithImpure().',
-				78,
+				120,
 			],
 			[
 				'Method AllMethodsArePure\SideEffectPure::impureWithPure() is marked as impure but does not have any side effects.',
-				88,
+				130,
 			],
 			[
 				'Method AllMethodsArePure\SideEffectImpure::nothingWithPure() is marked as impure but does not have any side effects.',
-				101,
+				143,
 			],
 			[
 				'Impure call to method AllMethodsArePure\Test::impure() in pure method AllMethodsArePure\SideEffectImpure::pureWithImpure().',
-				106,
+				148,
 			],
 		]);
 	}

tests/PHPStan/Rules/Pure/data/all-methods-are-pure.php

@@ -7,21 +7,42 @@
  */
 final class Foo
 {
-	function test(): void
+	function test(): int
 	{
+		return 1;
+	}
+
+	function testVoid(): void
+	{
+	}
+
+	/**
+	 * @phpstan-pure
+	 */
+	function pure(): int
+	{
+		return 1;
 	}
 
 	/**
 	 * @phpstan-pure
 	 */
-	function pure(): void
+	function pureVoid(): void
 	{
 	}
 
 	/**
 	 * @phpstan-impure
 	 */
-	function impure(): void
+	function impure(): int
+	{
+		return 1;
+	}
+
+	/**
+	 * @phpstan-impure
+	 */
+	function impureVoid(): void
 	{
 	}
 }
@@ -31,21 +52,42 @@ function impure(): void
  */
 final class Bar
 {
-	function test(): void
+	function test(): int
 	{
+		return 1;
+	}
+
+	function testVoid(): void
+	{
+	}
+
+	/**
+	 * @phpstan-pure
+	 */
+	function pure(): int
+	{
+		return 1;
 	}
 
 	/**
 	 * @phpstan-pure
 	 */
-	function pure(): void
+	function pureVoid(): void
 	{
 	}
 
 	/**
 	 * @phpstan-impure
 	 */
-	function impure(): void
+	function impure(): int
+	{
+		return 1;
+	}
+
+	/**
+	 * @phpstan-impure
+	 */
+	function impureVoid(): void
 	{
 	}
 }