Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged unions #1547

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Tagged unions #1547

merged 1 commit into from
Aug 27, 2022

Conversation

ondrejmirtes
Copy link
Member

No description provided.

@ondrejmirtes ondrejmirtes marked this pull request as ready for review August 27, 2022 06:33
@ondrejmirtes ondrejmirtes merged commit 40043e9 into 1.8.x Aug 27, 2022
@ondrejmirtes ondrejmirtes deleted the tagged-unions branch August 27, 2022 06:33
@ondrejmirtes ondrejmirtes changed the title WIP: Tagged unions Tagged unions Aug 27, 2022
@herndlm
Copy link
Contributor

herndlm commented Aug 27, 2022

I did not look into it before at all, but I'm amazed by how small the actual changes in this PR are. you did quite some precondition work already before though, right?

@ondrejmirtes
Copy link
Member Author

Before the vacation I commited this #1548 which famously fixed something like 18 issues 😅

On vacation I could not stop thinking about this and during the afternoon break when kids were asleep I couldn't help myself but do something about problems the previous code uncovered.

I've been fixing various related bugs, and the CI has been finally green last two days or so 😅 This dev cycle has been challenging to say the least.

Some of the notable fixes are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants