Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-tagged unions #1548

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Pre-tagged unions #1548

merged 7 commits into from
Jul 25, 2022

Conversation

ondrejmirtes
Copy link
Member

No description provided.

@ondrejmirtes ondrejmirtes marked this pull request as ready for review July 25, 2022 20:20
@ondrejmirtes ondrejmirtes changed the title WIP: Pre-tagged unions Pre-tagged unions Jul 25, 2022
@ondrejmirtes ondrejmirtes merged commit d33454d into 1.8.x Jul 25, 2022
@ondrejmirtes ondrejmirtes deleted the pre-tagged-unions branch July 25, 2022 20:26
@ondrejmirtes
Copy link
Member Author

FYI @herndlm this contains new HasOffsetValueType. I'm not certain it's gonna help you to improve in_array() but you can try it :)

@ondrejmirtes
Copy link
Member Author

It was so painful and hard to come up with something that works and doesn't break much stuff, the PHPStan issue bot comment flood is so worth it though :)

@ondrejmirtes
Copy link
Member Author

So worth it :)

Screenshot 2022-07-25 at 22 50 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant