take subtracted type into account in MixedType->isArray()

[staabm]

No description provided.

[staabm]

subtracting only array<int, string> could still leave e.g. a array<string, mixed> within the mixed.
therefore I am wondering, whether the only case where $mixed->isArray() can say NO is, when a general array is substracted?

[ondrejmirtes]

Exactly. Switching the callee and the argument works even when more than just an array are subtracted, like array|null for example.

[staabm]

I just see #1656 (comment), so I think we are on the same page.. will adjust the PR.

[ondrejmirtes]

While you're at it, please do all the other methods as well.

[staabm]

implemented in all methods I found useful.

here are a few notes:

• should isIterableAtLeastOnce return NO when isIterable returns NO?
• was not sure what todo with isOffsetAccessible and friends ..?
• was wondering whether isCallable should also use a $this->subtractedType->isSuperTypeOf(new CallableType(...)) construction instead?
  see

  phpstan-src/src/Type/MixedType.php

  Lines 130 to 140 in 9ff3322

  	public function isCallable(): TrinaryLogic
  	{
  	if (
  	$this->subtractedType !== null
  	&& $this->subtractedType->isCallable()->yes()
  	) {
  	return TrinaryLogic::createNo();
  	}
  	return TrinaryLogic::createMaybe();
  	}

[ondrejmirtes]

should isIterableAtLeastOnce return NO when isIterable returns NO?

Exactly, it should just call return $this->isIterable(). I don't think we can get more precise than that.

• was not sure what todo with isOffsetAccessible and friends ..?

Can we get a union of all offset-accessible types? Is it string|array|ArrayAccess? Yeah, probably.

• was wondering whether isCallable should also use a $this->subtractedType->isSuperTypeOf(new CallableType(...)) construction instead?

Yes, definitely, the current code is wrong.

[staabm]

implemented and rebased

[ondrejmirtes]

Thank you.