Fix numeric-string negated intersection #1639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#7814
As the docs says:
https://phpstan.org/writing-php-code/phpdoc-types#other-advanced-string-types
So,
numeric-string
should be also subtracted from any type not passedis_numeric
, becauseis_numeric
is thenumeric-string
determiner itself.But I've added a test that shows there's a bug with
numeric-string
subtraction frommixed
. It's stillmixed
. I would be glad if someone give me an advice how to fix it :)