Fix infinite loop when fully qualified callback is supplied #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the endless loop scenario reproducible in a AnalyzerIntegrationTest? |
cs278
force-pushed
the
fix-infinite-loop
branch
from
af6c1bc to
d165186
Compare
|
I've added a test case which curiously causes a segfault when run as part of the test suite matching: phpstan/phpstan#8290 |
|
The build failures (once I found them) don't appear to be related. |
This seemed to only cause a problem when running the code on PHP 7 and where the same file contained a native call to the same callback function. Example: <?php \array_filter([1], '\\is_int'); \is_int(1);
cs278
force-pushed
the
fix-infinite-loop
branch
from
d165186 to
f17624a
Compare
|
Anything else needed to get this merged please? |
|
Ondrey has problems with his computer and waits to get it repaired. Please be patient. |
|
I need to try out locally the test fails when the fix is reverted. |
I haven't got the test to fail locally instead PHP segfaults, not ideal, but it's not a pass! You need to run the code through Rector to downgrade it to PHP 7.2 to cause the failure, no idea why it works fine on PHP 8. 😕 |
|
I can reproduce the problem if I downgrade the code to 7.4 and run it on PHP 7.4. This is the stack trace: |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#8376
This seemed to only cause a problem when running the code on PHP 7 and where the same file contained a native call to the same callback function.
Example:
You can replicate the problem by running Rector over the code and then trying to analyse a file containing the above example using PHP 7.4.