TableErrorFormatter: visually differentiate phpstan assertion errors from rule errors #3951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
Green isn't the right choice when it's an error :) |
ondrejmirtes
requested changes
Apr 19, 2025
|
|
||
| if ( | ||
| $error->getIdentifier() !== null | ||
| && in_array($error->getIdentifier(), ['phpstan.type', 'phpstan.nativeType', 'phpstan.variable'], true) |
There was a problem hiding this comment.
Also would make sense for phpstan.dumpType and phpstan.unknownExpectation.
hehe.. I am too positive about my errors ;) updated the impl and the screenshot |
staabm
force-pushed
the
color-types
branch
2 times, most recently
from
83c7eca to
e7507f0
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR
after this PR