Skip to content

TableErrorFormatter: visually differentiate phpstan assertion errors from rule errors #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

TableErrorFormatter: visually differentiate phpstan assertion errors from rule errors #3951

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
731feda
TableErrorFormatter: visually differentiate phpstan assertion errors …
staabm Apr 19, 2025
b346401
Update TableErrorFormatter.php
staabm Apr 19, 2025
fb50821
Update TableErrorFormatter.php
staabm Apr 19, 2025
5e54cc4
use red text only
staabm Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Command/ErrorFormatter/TableErrorFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use function count;
use function explode;
use function getenv;
use function in_array;
use function is_string;
use function ltrim;
use function sprintf;
Expand Down Expand Up @@ -117,6 +118,14 @@ public function formatErrors(

$message .= "\n✏️ <href=" . OutputFormatter::escape($url) . '>' . $title . '</>';
}

if (
$error->getIdentifier() !== null
&& in_array($error->getIdentifier(), ['phpstan.type', 'phpstan.nativeType', 'phpstan.variable', 'phpstan.dumpType', 'phpstan.unknownExpectation'], true)
) {
$message = '<fg=red>' . $message . '</>';
}

$rows[] = [
$this->formatLineNumber($error->getLine()),
$message,
Expand Down
Loading