Update xml_*_handler signature #4254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
xml__handler
branch
from
4aa3680 to
84a90f6
Compare
|
Tests fail for PHP < 8.4 because of php-src stub. If the stub are wrong, I'm unsure how it will be needed to be fixed on PHPStan (extractor ?) side... |
|
Confirmed from php/php-src#12340 (comment) that the stub was wrong on php-src side. |
VincentLanglet
force-pushed
the
xml__handler
branch
from
84a90f6 to
13b49d8
Compare
VincentLanglet
force-pushed
the
xml__handler
branch
from
13b49d8 to
22f1ea8
Compare
|
This pull request has been marked as ready for review. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of https://github.com/JetBrains/phpstorm-stubs/pull/1773/files
Closes phpstan/phpstan#9970