mb_* fatal errors on php8 with invalid encoding #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new rule to check this would be nice! |
staabm
force-pushed
the
invalid-encoding
branch
from
0018251
to
50f6d0b
Compare
|
Do you think we could merge this without a new rule? I have other priorities atm |
ondrejmirtes
requested changes
Feb 14, 2022
| @@ -86,9 +88,14 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection, | |||
| } | |||
|
|
|||
| if (count($results) === 1) { | |||
| $invalidEncodingReturn = new ConstantBooleanType(false); | |||
| if ($this->phpVersion->getVersionId() >= 80000) { | |||
There was a problem hiding this comment.
This needs a descriptive method instead. Check the class if there's already a method that would match the situation, otherwise implement one :)
There was a problem hiding this comment.
implemented PhpVersion->throwsOnInvalidMbStringEncoding()
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see