Use minheap as timeout container and fix collision of multiple SelectConnection timeouts with same deadline and callback #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thSameDeadlineAndCallback
vitaly-krugl
changed the title
…sWithSameDeadlineAndCallback
vitaly-krugl
force-pushed
the
fix-multiple-timers-same-deadline
branch
2 times, most recently
from
970c2d3
to
5bd1a04
Compare
vitaly-krugl
force-pushed
the
fix-multiple-timers-same-deadline
branch
from
5495577
to
676e7e9
Compare
vitaly-krugl
force-pushed
the
fix-multiple-timers-same-deadline
branch
from
8b7f4ff
to
84b1061
Compare
vitaly-krugl
force-pushed
the
fix-multiple-timers-same-deadline
branch
from
84b1061
to
90a32c8
Compare
vitaly-krugl
changed the title
vitaly-krugl
changed the title
… signature. Remove errant param documentation from Poller constructors.
vitaly-krugl
changed the title
|
cc @lukebakken Ready for review |
…OLoop to the poller in order to prevent cyclical references that interfere with garbage collection.
|
I tried to use weakref and it resulted in test failures. I will be working through it shortly |
…ods, since instance methods have temporary references
|
@lukebakken - this is ready for review. Thanks! |
|
@lukebakken, do you anticipate an opportunity to review this in the near future? My next PR #956 that implements the thread-safe callback request feature in BlockingConnection and SelectConnection builds on this PR. Thx! |
|
@vitaly-krugl I'll get it today. I didn't notice that "DO NOT MERGE" had been removed from the title. |
lukebakken
approved these changes
Feb 16, 2018
|
Thank you for reviewing, @lukebakken! |
lukebakken
pushed a commit
that referenced
this pull request
Apr 16, 2018
…adline Use minheap as timeout container and fix collision of multiple SelectConnection timeouts with same deadline and callback (cherry picked from commit 0e13941)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that the failed coverage test results from pika's encrypted credentials configuration issue.)
hash(frozenset(value.items()))used by the legacy implementation ofSelectConnection's_PollerBase.add_timeoutreadily results in timer id collision if multiple timers have very close deadlines and same callback. See failedTestViabilityOfMultipleTimeoutsWithSameDeadlineAndCallbacktest results in https://ci.appveyor.com/project/gmr/pika/build/1.0.409. This is aided by Windowstime.time()having lower resolution than on Linux. However, on a faster machine, the same problem would also likely show up on linux, and hashes aren't guaranteed to be unique for all input set. And I recall getting it on my dev MacBookPro a long time ago.