Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to python3 for next major Mopidy release #3

Merged
merged 18 commits into from
Jan 30, 2020
Merged

Port to python3 for next major Mopidy release #3

merged 18 commits into from
Jan 30, 2020

Conversation

Gadgetoid
Copy link
Member

Aims to fix #1

@jodal
Copy link

jodal commented Dec 7, 2019

To fix the build error here, you need to:

You only need to do this for the first repo in your org you use with CircleCI.

Switches from use of playback controller (deprecated) to mixer volume as mentioned in #1

Uses `get_state()` instead of `state`
This currently uses three files copy-n-pasted from upstream Mopidy to provide dummy interfaces for mixer, backend and audio.

These dummy files seem a little janky- should they be part of a mopidy-test package so that they stay in-sync with Mopidy's API? Since otherwise tests may?? pass that fail against the real Mopidy. Maybe?
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6058b28). Click here to learn what that means.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   88.88%           
=========================================
  Files             ?        2           
  Lines             ?       90           
  Branches          ?        0           
=========================================
  Hits              ?       80           
  Misses            ?       10           
  Partials          ?        0
Impacted Files Coverage Δ
mopidy_raspberry_gpio/pinconfig.py 77.77% <77.77%> (ø)
mopidy_raspberry_gpio/frontend.py 96.29% <96.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6058b28...6b90387. Read the comment docs.

@Gadgetoid Gadgetoid merged commit bcceb60 into master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Mopidy-Raspberry-GPIO to Python 3
3 participants