Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-diff: update tidb dependency #741

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 21, 2023

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Update tidb dependency, so need update tiflow, and tiflow repo use 20230823131104-05aa17143df8. So let's use this version here, too

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Sep 21, 2023
@zimulala
Copy link
Contributor Author

/retest-required

@zimulala
Copy link
Contributor Author

/test integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

@zimulala: No presubmit jobs available for pingcap/tidb-tools@master

In response to this:

/test integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/run-integration-test

@wuhuizuo
Copy link
Contributor

/test integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

@wuhuizuo: No presubmit jobs available for pingcap/tidb-tools@master

In response to this:

/test integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/run-integration-tests

1 similar comment
@zimulala
Copy link
Contributor Author

/run-integration-tests

@Leavrth
Copy link
Contributor

Leavrth commented Sep 21, 2023

blocked by #743

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-22 02:24:20.357466487 +0000 UTC m=+829826.325054519: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 22, 2023
@zimulala
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants