Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tls certificate #743

Merged
merged 6 commits into from
Sep 22, 2023
Merged

update tls certificate #743

merged 6 commits into from
Sep 22, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Sep 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #744

What is changed and how it works?

openssl x509 -in ./client.crt -noout -dates
notBefore=Sep 21 15:09:01 2023 GMT
notAfter=Feb  6 15:09:01 2051 GMT

Check List

Tests

  • Integration test

Release Note

None

@Leavrth
update tls certificate
df8f460 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
update tls certificate
10728ad 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Merge branch 'update-tls' of https://github.com/leavrth/tidb-tools in…
dac01fd 
…to update-tls
@Leavrth
add the generation script
7c6bbaf 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix typos
17bed35 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth Leavrth mentioned this pull request Sep 21, 2023
Merged
@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 21, 2023

/release-note-none

zimulala
zimulala approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-22 02:00:46.465279271 +0000 UTC m=+828412.432867327: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 22, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 22, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

@Leavrth: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 22, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 206703b into pingcap:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
approved contribution lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the tls certificate in the integration test is outdate
2 participants
@Leavrth @zimulala